feat(chip): set default shape to soft for ios and md theme and round for ionic theme #29375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
brandyscarney
commented
Apr 22, 2024
brandyscarney
commented
Apr 22, 2024
brandyscarney
commented
Apr 22, 2024
...ents/chip/test/a11y/chip.e2e.ts-snapshots/chip-large-contents-md-ltr-Mobile-Chrome-linux.png
Outdated
Show resolved
Hide resolved
brandyscarney
changed the title
brandyscarney
changed the title
brandyscarney
commented
Apr 24, 2024
sean-perkins
reviewed
May 1, 2024
brandyscarney
requested review from
sean-perkins
and removed request for
liamdebeasi
sean-perkins
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
The
shapeproperty defaults toundefinedwhich evaluates to the "Soft" shape for theionictheme and the "Round" shape for theios/mdthemes.ionic)ios)md)undefined4px16px16px"round"999px"rectangular"0pxWhat is the new behavior?
ionic)ios)md)"soft"4px10px8px"round"999px999px999px"rectangular"0px0px0pxshapeproperty to"soft"foriosandmdthemes and"round"for the ionic theme.border-radiusto apply to the shape classes instead of:hostiostheme to use10pxfor"soft"as this was taken from the App Store:mdtheme to use8pxfor"soft"as this is taken from the Material Design 3 guidelines & the previous value of16pxis the equivalent of the999pxround shape due to the height being32px"round"and"rectangular"shapes iniosandmdthemesDoes this introduce a breaking change?
BREAKING CHANGE:
The
border-radiusof theiosandmdchip now defaults to10pxand8px, respectively, instead of16pxin accordance with the iOS and Material Design 3 guidelines. To revert to the previous appearance, set theshapeto"round", or override the--border-radiusCSS variable to specify a different value.