Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(many): expand global config for icons #29373

Merged
merged 29 commits into from May 8, 2024
Merged

feat(many): expand global config for icons #29373

merged 29 commits into from May 8, 2024

Conversation

thetaPC
Copy link
Contributor

@thetaPC thetaPC commented Apr 22, 2024

Issue number: internal


What is the current behavior?

Developers have to override icons per component instance. For example, to customize the clear input icon on Input, developers must set the clearInputIcon property on every instance of the component.

What is the new behavior?

  • The global config has been updated to let developers set icons at a higher level.
  • Components have been updated to render the icons in the following priority: "Component property > Global config > Default"

Does this introduce a breaking change?

  • Yes
  • No

Other information

Dev build: 8.0.0-dev.11713988726.1e82b9a0

Copy link

vercel bot commented Apr 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2024 10:55pm

core/src/utils/config.ts Outdated Show resolved Hide resolved
core/src/components/toggle/toggle.tsx Outdated Show resolved Hide resolved
core/src/components/select/select.tsx Outdated Show resolved Hide resolved
core/src/components/searchbar/searchbar.tsx Show resolved Hide resolved
@thetaPC thetaPC merged commit a58d9fa into next May 8, 2024
45 checks passed
@thetaPC thetaPC deleted the FW-6062 branch May 8, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants