Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(): create reusable test header #29240

Draft
wants to merge 1 commit into
base: next
Choose a base branch
from
Draft

Conversation

mapsandapps
Copy link
Contributor

@mapsandapps mapsandapps commented Mar 29, 2024

Implemented

There's now a reusable header component that will allow a developer of Ionic Framework to toggle a number of things while viewing the index.html test files. This component can be reused across any of these files and includes:

  • Dark mode toggle
  • Theme switcher for iOS, MD, and Ionic themes
  • LTR/RTL

It also has a slot so that settings can be added, e.g. settings that are specific to the component being tested like the ones we have for some Datetime tests.

Yet to do

  1. I wasn't sure where to put the test-header.tsx file nor did I figure out how to prevent it from being included in Ionic Framework.

  2. Other functionality we might want to add to the popover:

    • Mode
    • Locale
    • Maybe more?
  3. Currently, not all of the options persist when selecting other options. Several of the options are settable via URL query parameters. We may want to update the component to add and remove params accordingly (like it currently does for theme, so they will persist.


Screenshot 2024-03-29 at 1 41 43 PM

Screenshot 2024-03-29 at 1 47 02 PM

Other information

@github-actions github-actions bot added package: core @ionic/core package package: angular @ionic/angular package package: vue @ionic/vue package package: react @ionic/react package labels Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: angular @ionic/angular package package: core @ionic/core package package: react @ionic/react package package: vue @ionic/vue package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant