Skip to content

docs: Clarify AndroidBottomSheet.height #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

docs: Clarify AndroidBottomSheet.height #65

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,10 +284,10 @@ Defines the options for opening a URL in the system browser.

#### AndroidBottomSheet

| Prop | Type | Description |
| ------------- | -------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------- |
| **`height`** | <code>number</code> | Sets the height of the bottom sheet. This will be a minimum of 50% of the screen's height. If no value is passed, we will default to the minimum value. |
| **`isFixed`** | <code>boolean</code> | Sets whether the bottom sheet is fixed. |
| Prop | Type | Description |
| ------------- | -------------------- | ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
| **`height`** | <code>number</code> | Sets the height of the bottom sheet, in pixels. Custom tabs will set the bottom height to at least 50% of the screen. If no value is passed, it will default to the minimum value. |
| **`isFixed`** | <code>boolean</code> | Sets whether the bottom sheet is fixed. |


#### iOSSystemBrowserOptions
Expand Down
6 changes: 3 additions & 3 deletions src/definitions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,9 +117,9 @@ export interface iOSSystemBrowserOptions {
}

export interface AndroidBottomSheet {
/** Sets the height of the bottom sheet.
* This will be a minimum of 50% of the screen's height.
* If no value is passed, we will default to the minimum value. */
/** Sets the height of the bottom sheet, in pixels.
* Custom tabs will set the bottom height to at least 50% of the screen.
* If no value is passed, it will default to the minimum value. */
height: number;
/** Sets whether the bottom sheet is fixed. */
isFixed: boolean;
Expand Down