Skip to content

fix(android,ios): properly return errors #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 20, 2025
Merged

fix(android,ios): properly return errors #54

merged 6 commits into from
Mar 20, 2025

Conversation

alexgerardojacinto
Copy link
Contributor

Changes

  • Fixes Android and iOS native code to return both an error message and code, instead of simply returning a message. This is necessary for this plugin to be aligned with its Cordova counterpart, and to be used by OutSystems apps.
  • Also updates the example-app to show the error that is returned in invalidScheme.

Tests

  • Tested with example-app.
  • Tested with OutSystems app using the Capacitor plugin.

@alexgerardojacinto alexgerardojacinto self-assigned this Mar 20, 2025
@alexgerardojacinto alexgerardojacinto merged commit 383d67f into development Mar 20, 2025
4 checks passed
@alexgerardojacinto alexgerardojacinto deleted the fix/RMET-4129/fixing-errors branch March 20, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andredestro andredestro andredestro approved these changes

@OS-pedrogustavobilro OS-pedrogustavobilro OS-pedrogustavobilro approved these changes

@ItsChaceD ItsChaceD Awaiting requested review from ItsChaceD

Assignees

@alexgerardojacinto alexgerardojacinto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexgerardojacinto @andredestro @OS-pedrogustavobilro