-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add details on submitting extra files #55
Conversation
The FAQ, guidelines and rules have been updated to reflect recent discussions and modifications to the maximum number of files. A new FAQ entry has been added. The guidelines talk about including extra tarballs and rule 17 has been updated as well. Some of this was copied directly from discussion with Landon. Some minor other fixes were made in the guidelines and rules (mostly wording).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the checks fail due to some missing links:
=-=-=-=-= IOCCC begin make find_missing_links =-=-=-=-=
bin/find-missing-links.sh -v 1
bin/find-missing-links.sh: debug[1]: start scan for missing links
# Missing file linked in: next/guidelines.md
# Markdown line: FAQ on "[.auth.json](faq.html#auth_json)",
next/faq.html
# Missing file linked in: next/guidelines.md
# Markdown line: FAQ on "[.info.json](faq.html#info_json)",
next/faq.html
bin/find-missing-links.sh: ERROR: 2 missing link(s) found
make[1]: *** [Makefile:569: find_missing_links] Error 1
make[1]: Leaving directory '/home/runner/work/winner/winner'
make: *** [Makefile:612: test] Error 2
Error: Process completed with exit code 2.
Oh thanks. I'll fix that. For some reason I'm not getting notifications about that (I blame iOS 18). This happened yesterday or the day before too. |
Oh I forgot the |
Okay that's weird .. not seeing it in my copy. I'll check more. |
$ git grep '#(auth|info)_json' guidelines.md
next/guidelines.md:602:FAQ on "[.auth.json](../faq.html#auth_json)".
next/guidelines.md:604:FAQ on "[.info.json](../faq.html#info_json)".
next/guidelines.md:668:FAQ on "[.auth.json](../faq.html#auth_json)"
next/guidelines.md:670:FAQ on "[.info.json](../faq.html#info_json)"
? What am I missing ? I guess I'll run that rule and see what happens. |
Too bad the script doesn't show the line number ... |
I'll try checking in this commit. Maybe that'll help me locate it. |
What's bizarre is it seems nothing of the sort was changed in the diff. But I could have sworn I did type that in the guidelines today. What am I missing? |
Oh! I think I know why. It's because I checked out the most recent commits before mine and that modified it. So I have to switch back to the branch I was on and then fix. |
That was indeed it. Fixing. |
This should fix it (I think). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @xexyl
Happy to help. |
The FAQ, guidelines and rules have been updated to reflect recent discussions and modifications to the maximum number of files.
A new FAQ entry has been added. The guidelines talk about including extra tarballs and rule 17 has been updated as well. Some of this was copied directly from discussion with Landon.
Some minor other fixes were made in the guidelines and rules (mostly wording).