Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

United Kingdom is GB, not UK #48

Merged
merged 1 commit into from
Jan 16, 2025
Merged

United Kingdom is GB, not UK #48

merged 1 commit into from
Jan 16, 2025

Conversation

didgogns
Copy link
Contributor

  • ISO_3166-1 code for United Kingdom is GB
  • Among 15 winners from United Kingdom, 11 have location_code GB and 4 have location_code UK

Copy link
Contributor

@lcn2 lcn2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough request. Both GB and UK are reserved by that government, but we are happy to go with your selection, @didgogns.

@xexyl
Copy link
Contributor

xexyl commented Jan 16, 2025

Fair enough request. Both GB and UK are reserved by that government, but we are happy to go with your selection, @didgogns.

Another nice thing is for consistency.

Do you want me to build the html files @lcn2 ? Or will you take care of it ?

@xexyl
Copy link
Contributor

xexyl commented Jan 16, 2025

.. also I wonder what location(1) shows. I can look and fix if necessary.

@xexyl
Copy link
Contributor

xexyl commented Jan 16, 2025

Okay location(1) actually shows both it looks like.

$ location |grep 'Kingdom of Great Brit'
GB	United Kingdom of Great Britain and Northern Ireland
UK	United Kingdom of Great Britain and Northern Ireland

... so that's good.

@lcn2
Copy link
Contributor

lcn2 commented Jan 16, 2025

BTW: @didgogns

We thank you for making the correct choice to modify the JSON files.

In about a day or so when we return to a real keyboard (instead of a cell phone), we will generate the web page update that will result from your change. When that is complete the IOCCC web site will reflect your change.

Thanks again image, @didgogns 👍

@lcn2 lcn2 merged commit 9851436 into ioccc-src:master Jan 16, 2025
1 check passed
@lcn2
Copy link
Contributor

lcn2 commented Jan 16, 2025

Fair enough request. Both GB and UK are reserved of that government, but we are happy to go with your selection, @didgogns.

Another nice thing is for consistency.

Do you want me to build the html files @lcn2 ? Or will you take care of it ?

Please build the HTML files, @xexyl

@xexyl
Copy link
Contributor

xexyl commented Jan 16, 2025

BTW: @didgogns

We thank you for making the correct choice to modify the JSON files.

In about a day or so when we return to a real keyboard (instead of a cell phone), we will generate the web page update that will result from your change. When that is complete the IOCCC web site will reflect your change.

I can do this instead if you wish Landon ?

Just have to rebuild the authors page and possibly the index.html pages. Can you think of any other web page that needs to be updated?

@xexyl
Copy link
Contributor

xexyl commented Jan 16, 2025

Fair enough request. Both GB and UK are reserved of that government, but we are happy to go with your selection, @didgogns.

Another nice thing is for consistency.
Do you want me to build the html files @lcn2 ? Or will you take care of it ?

Please build the HTML files, @xexyl

Will do if you remind me what besides the authors page has to be updated? Ah. Locations file too.. I'll check if any others have to be updated.

@xexyl
Copy link
Contributor

xexyl commented Jan 16, 2025

Okay the entry pages too. Will do!

@xexyl
Copy link
Contributor

xexyl commented Jan 16, 2025

Rebuilding web pages now ...

@xexyl
Copy link
Contributor

xexyl commented Jan 16, 2025

Done and committed! I will do the fixes in the mkiocccentry in a while: have to go afk now.

@xexyl
Copy link
Contributor

xexyl commented Jan 16, 2025

... and after that, unrelated, I will try and fix the make test issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants