Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make IOCCC status text consistent with JSON status #38

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

xexyl
Copy link
Contributor

@xexyl xexyl commented Dec 31, 2024

The status showed 'The IOCCC is not yet open' to indicate it is in pending status. But it would be better to match the actual status itself especially as the status.html file explains pending status, not 'not yet open'. At a quick glance it is easy to miss especially for those of us who have worked on the repo for a long time and in particular those who worked on the status.html file a lot.

This updated files in inc/, bin/ and next/ but I cheated and used sgit to do this. I then rebuilt the html files. A previous minor grammar problem in rules was fixed as well.

The status showed 'The IOCCC is not yet open' to indicate it is in
pending status. But it would be better to match the actual status
itself especially as the status.html file explains pending status, not
'not yet open'. At a quick glance it is easy to miss especially for
those of us who have worked on the repo for a long time and in
particular those who worked on the status.html file a lot.

This updated files in inc/, bin/ and next/ but I cheated and used sgit
to do this. I then rebuilt the html files. A previous minor grammar
problem in rules was fixed as well.
Copy link
Contributor

@lcn2 lcn2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are good improvements in consistency, @xexyl, thank you 🙏

@lcn2 lcn2 merged commit eabeb29 into ioccc-src:master Dec 31, 2024
1 check passed
@xexyl
Copy link
Contributor Author

xexyl commented Dec 31, 2024

These are good improvements in consistency, @xexyl, thank you 🙏

You are most welcome. I was uncertain about the status until I checked the status.json file. I knew you had said it would be changed to pending but ...

Tomorrow I'll try and tackle the other things. I seem to think I'm supposed to be replying to another thing about subdirectories in submissions too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants