Feature(UI): Add text tool to canvas #8723
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…DustyShoe/InvokeAI into Feature/UI-Add-Text-tool-to-canvas
github-actions
bot
added
frontend
DustyShoe
changed the title
…ithout commiting text.
…llback, minor tweaks
joshistoast
reviewed
Dec 30, 2025
|
|
||
| let attempts = 0; | ||
| const MAX_ATTEMPTS = 5; | ||
| const tryFocus = () => { |
Contributor
There was a problem hiding this comment.
The idea here of counting attempts to try to focus it feels like an ungraceful band-aid solution.
Contributor
Author
There was a problem hiding this comment.
What would be the better solution here in your opinion?
Contributor
There was a problem hiding this comment.
What behavior is it fixing? If it's event bubbling, I'd probably suggest a callback ref pattern instead
Contributor
Author
There was a problem hiding this comment.
It was probing, if the input field is ready and auto-enables typing mode. Changed to focus logic to a single RAF per session, preventing repeated focus attempts.
joshistoast
reviewed
Dec 30, 2025
| const handleCompositionStart = useCallback(() => setIsComposing(true), []); | ||
| const handleCompositionEnd = useCallback(() => setIsComposing(false), []); | ||
|
|
||
| const containerMetrics = useMemo(() => { |
Contributor
There was a problem hiding this comment.
Maybe a name like textContainerData would be more descriptive here
Contributor
Author
There was a problem hiding this comment.
Good point! Changed that.
…n CanvasTextOverlay.tsx Renamed containerMetrics to textContainerData in CanvasTextOverlay.tsx Fixed mouse cursor disapearing during typing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Canvas Basic Text Tool!
Summary:
2025-12-30.13-29-23.mp4
Related Issues / Discussions
The fonts information is stored in
invokeai\frontend\web\src\features\controlLayers\text\textConstants.tsIf anyone have an opinion what fonts and fallbacks should be used, please write in comments. There's 10 fonts to choose ATM and i'd like to make selection as diverse as possible.
QA Instructions
Merge Plan
Checklist
What's Newcopy (if doing a release after this PR)