-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved object and tracker fiducial registration UI #786
base: master
Are you sure you want to change the base?
Conversation
New class OrderedFiducialButtons for creating fiducial buttons and keeping track of which button to set next.
Implement object registration using OrderedFiducialButtons. Fiducial buttons now colored like with tracker fiducials for improved clarity. Less clicking required to record fiducials.
Use OrderedFiducialButtons class for tracker fiducials. Changed fiducial registration order from LE, RE, NA to LE, NA, RE. Fiducial registration order can now be changed more easily through constants.py. Can click on fiducial buttons to record fiducials out of default order.
Thanks for the great PR. A couple of edits more: In the Coil registration dialog:
In the Tracker registration tab:
|
Changed labels in GUI: Stimulator -> TMS Coil Tracker Registration -> Patient Registration Enhanced tooltips.
"Fixed fiducial" for coil registration now collected automatically after collecting the anterior fiducial for certain trackers. Added list of trackers with which to collect the fixed coordinate separately to constants.py. Fixed coordinate hidden from GUI when not needed. Hiding the Fastrak sensor port and the dynamic reference combobox now use the same condition.
OrderedFiducialButtons now colors the fiducial ball and text actors to match the buttons. Use colorblind-friendly colors for ball and text actors.
@Rakhesis I remember other tiny fix that can be added here. In Image coregistration, after all 3 buttons have been recorded, disable the "Start registration". When it is kept enabled, it will also keep the "cross" enabled which prevents the use of other buttons, like measurement and brightness adjustment. It's nearly impossible for the user to realize that the "Start registration" in the Image panel should be manually stopped. |
In the Patient registration tab, the UI is still not updating in MacOS after the "Record fiducial" button is pressed. The UI is only updated after hiding and showing the tab again, or minimizing and maximizing the window. Some "Refresh" command is missing. |
In this PR, @Rakhesis made a fix to hide the "Fixed" coordinate for Polaris and Optitrack and record the necessary coordinate already with the other clicks. It also hides the dynamic and sensor icons for these specific trackers. Could you test with your navigation setup there that all is working fine. I tested the basic UI and all is correct, except for a minor update issue in MacOS. |
…ation Using the cross tool toggle button will automatically disable image registration. This will prevent the cross tool from getting stuck turned on.
New class for creating fiducial buttons and keeping track of which button to set next: used to reimplement fiducial buttons for object and tracker.
Object fiducials:
Tracker fiducials: