Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: get purpose legitimate interests #653

Merged
merged 4 commits into from
Nov 12, 2024
Merged

Conversation

vlsido
Copy link
Contributor

@vlsido vlsido commented Nov 9, 2024

Description

Add a function to get purpose legitimate interests.

This library exposes a function to get purpose consents; however it lacks a function to get the status of purpose legitimate interests. Knowing which legitimate interests were selected (or rather deselected) is essential. This information helps determine what type of ads will be served to the user (personalized, non-personalized or limited ads), if any.
More about it here:
https://developers.google.com/admob/ios/privacy/ad-serving-modes

Related issues

N/A

Release Summary

Checklist

  • I read the Contributor Guide
    and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in __tests__e2e__
    • jest tests added or updated in __tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-google-mobile-ads is great? Please consider supporting the project with any of the below:

  • 👉 Star this repo on GitHub ⭐️
  • 👉 Follow Invertase on Twitter

🔥

Copy link

docs-page bot commented Nov 9, 2024

To view this pull requests documentation preview, visit the following URL:

docs.page/invertase/react-native-google-mobile-ads~653

Documentation is deployed and generated using docs.page.

@CLAassistant
Copy link

CLAassistant commented Nov 9, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Certainly seems reasonable to me and is a clone-stamp of the previous consents one (that's a good thing in that if that one works, this one should work - there's an opportunity for a refactor to reduce code duplication but that's a nitpick)

Thanks!

@mikehardy
Copy link
Collaborator

@vlsido can you sign the CLA for this one - if you follow the details link it should describe how

@mikehardy mikehardy added workflow: pending merge Waiting on CI or question responses to merge, but otherwise ready CLA: blocked needs CLA signed before merge labels Nov 11, 2024
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 42.96%. Comparing base (a34c7ba) to head (d2cadc1).
Report is 67 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #653      +/-   ##
==========================================
- Coverage   43.72%   42.96%   -0.75%     
==========================================
  Files          30       31       +1     
  Lines         549      575      +26     
  Branches      151      156       +5     
==========================================
+ Hits          240      247       +7     
- Misses        309      328      +19     

@vlsido
Copy link
Contributor Author

vlsido commented Nov 12, 2024

@mikehardy Signed!

@mikehardy mikehardy removed workflow: pending merge Waiting on CI or question responses to merge, but otherwise ready CLA: blocked needs CLA signed before merge labels Nov 12, 2024
@mikehardy mikehardy merged commit f711a2c into invertase:main Nov 12, 2024
10 of 12 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 12, 2024
## [14.3.0](v14.2.5...v14.3.0) (2024-11-12)

### Features

* get purpose legitimate interests ([#653](#653)) ([f711a2c](f711a2c))
@mikehardy
Copy link
Collaborator

🎉 This PR is included in version 14.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants