fix: unnecessary changes to upload-crashlytics-symbols script each time configure project #391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OutdatedGuy
had a problem deploying
to
CI Environment
GitHub Actions
Failure
OutdatedGuy
had a problem deploying
to
CI Environment
GitHub Actions
Failure
OutdatedGuy
had a problem deploying
to
CI Environment
GitHub Actions
Failure
Contributor
Author
|
Hi @russellwheatley @SelaseKay, can you review this PR? |
github-actions
bot
added
the
Needs Attention
russellwheatley
approved these changes
May 2, 2025
Member
russellwheatley
left a comment
russellwheatley
left a comment
There was a problem hiding this comment.
@OutdatedGuy - thanks, that LGTM 👍
russellwheatley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checks if
upload-crashlytics-symbolsscript exists and only updates the contentsshell_scriptif it exists.fixes #272
Type of Change
feat-- New feature (non-breaking change which adds functionality)fix-- Bug fix (non-breaking change which fixes an issue)!-- Breaking change (fix or feature that would cause existing functionality to change)refactor-- Code refactorci-- Build configuration changedocs-- Documentationchore-- Chore