fix: extra filter not needed param

[edivalentinitu]

❤️ Thank you for your contribution!

Description

Please describe briefly your pull request.

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

• I'm aware of the code of conduct.
• I've created logical separate commits and followed the commit message format.
• I've added relevant test cases.
• I've added relevant documentation.
• I've marked translation strings.
• I've identified the copyright holder(s) and updated copyright headers for touched files (>15 lines contributions).
• I've NOT included third-party code (copy/pasted source code or new dependencies).
  • If you have added third-party code (copy/pasted or new dependencies), please reach out to an architect on Discord.

Frontend

• I've followed the CSS/JS and React guidelines.
• I've followed the web accessibility guidelines.
• I've followed the user interface guidelines.

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

1. You license your contribution under the same terms as the current repository’s license.
2. You agree that you have the right to license your contribution under the current repository’s license.

[edivalentinitu]

Original issue: custom requests from https://github.com/tu-graz-library/invenio-curations are now shown when searching for a user's requests.

Cause: apparently this line. But I could not replicate the problem in the standard invenio implementation.

Reasons: Following these lines: https://github.com/inveniosoftware/invenio-records-resources/blob/a9389e4cb179d6ab515282d37b60983bef8c06b0/invenio_records_resources/services/records/service.py#L140 this extra filter prevents requests that come with default_filter = MatchAll() queries from being shown. In the standard invenio implementation, this is hidden by Status wrapper in the PermissionPolicy, for example: can_read = [Status(["created"], [Creator()])], which generates a default filter query that is not affected by this extra filter.
Second reason is that must query does not need minimum_should_match parameter.

Debug:
default_filter before: MatchAll()
extra filter: Bool(minimum_should_match=1, must=[Bool(must_not=[Term(status='created')])])
default filter after: Bool(minimum_should_match=1, must=[Bool(must_not=[Term(status='created')])])

[zzacharo]

Hey @edivalentinitu , thanks for the commit! I understand that the minimum_should_match=1 is redundant with the must operation but I think don't understand how it solved the problem you described.... Could you please elaborate a bit more on what is the issue?

[edivalentinitu]

Because our usecase does not generate search filters based on permissions, the only filter left was this extra filter and the search is somehow not evaluated correctly. There are no created requests, yet still the search returns no values. I am no opensearch expert and at first I just observed that if I remove this redundant param, the search for our usecase works ok, but I am open to suggestions if there could be another way of dealing with this.

[zzacharo]

@slint do you see maybe any hidden potential problem?

[slint]

@slint do you see maybe any hidden potential problem?

Just from reading https://docs.opensearch.org/docs/latest/query-dsl/minimum-should-match/#default-minimum_should_match-value, since it doesn't document what happens when you pass minimum_should_match without any should clauses, I agree with removing the parameter, or else it's basically either a "no-op", "undefined behaviour", or an error.