custom-fields: forward the field ID to React #3138
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added an injection of the field ID (e.g. `cern:department`) to the React UI widget chosen for the custom field via a new `id` prop. * This is consumed by the new function in inveniosoftware/react-invenio-forms#298 and used to allow developers to dynamically parametrize their own custom fields based on the form state. * This is not a breaking change and shouldn't affect any existing custom fields
palkerecsenyi
force-pushed
the
forward-id-to-custom-fields
branch
from
da31d13 to
82abd64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes inveniosoftware/react-invenio-forms#297
Releasing this PR before inveniosoftware/react-invenio-forms#298 should not cause any problems as existing React widgets will simply ignore the
idprop.Description
Added an injection of the field ID (e.g.
cern:department) to the React UI widget chosen for the custom field via a newidprop.This is consumed by the new function in overridable: Implement for custom fields react-invenio-forms#298 and used to allow developers to dynamically parametrize their own custom fields based on the form state.
This is not a breaking change and shouldn't affect any existing custom fields