Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

diff: fix comparison of sets #133

Merged
merged 3 commits into from
Dec 13, 2019
Merged

diff: fix comparison of sets #133

merged 3 commits into from
Dec 13, 2019

Conversation

jirikuncar
Copy link
Member

  • Adds missing return statement to avoid yielding CHANGE for sets.

(addresses #131)

@jirikuncar
diff: fix comparison of sets
12da7ea 
* Adds missing return statement to avoid yielding CHANGE for sets.
jirikuncar
jirikuncar commented Dec 11, 2019
View reviewed changes
dictdiffer/__init__.py Outdated Show resolved Hide resolved
@jirikuncar jirikuncar mentioned this pull request Dec 11, 2019
Open
@jirikuncar jirikuncar requested a review from a team December 11, 2019 11:39
@danielduhh danielduhh mentioned this pull request Dec 11, 2019
Merged
danielduhh
danielduhh approved these changes Dec 11, 2019
View reviewed changes
Copy link
Contributor

@danielduhh danielduhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I've verified it works. See #134 for unit tests

Thanks!! 💪

@danielduhh
Copy link
Contributor

Any chance you can expedite a release of this? 🙏 @jirikuncar

@jirikuncar jirikuncar merged commit 5601b11 into master Dec 13, 2019
@jirikuncar jirikuncar deleted the jirikuncar/fix-sets branch December 13, 2019 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielduhh danielduhh danielduhh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jirikuncar @danielduhh