-
Notifications
You must be signed in to change notification settings - Fork 760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmake_modules/FindSqlite3.cmake
breaks transitive dependencies.
#1250
Comments
matlabbe
added a commit
that referenced
this issue
Mar 23, 2024
I implemented the second suggestion. You could try this tag 0.21.4.1 on your pull request. |
This was referenced Mar 24, 2024
I didn't update my PR which discovered the problem, but I'm building successfully with 0.21.4.1 in a more general review of the vcpkg port, microsoft/vcpkg#37651. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Since CMake 3.14, there is an official
FindSQLite3.cmake
, variable prefixSQLite3
, and an imported target.rtabmap comes with
FindSqlite3.cmake
, variable prefixSqlite3
.On case-insensitive filesystems (Windows), this can break finding downstream dependencies with
find_dependency(SQLite3)
. This was noticed in vcpkg when updating PROJ, via a rtabmap > opencv > vtk > proj > sqlite3 dependency chain.Possible solutions:
Tentative patch in https://github.com/microsoft/vcpkg/pull/37650/files#diff-0a2a39d0c34a319ba9d49bc64e1da201038a1311b2e18368cab394a84353d439
The text was updated successfully, but these errors were encountered: