feat!: change $t overloaded signature for Legacy API mode
#1832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying vue-i18n-next with
|
| Latest commit: |
396c9ab
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7ee48bc8.vue-i18n-next.pages.dev |
| Branch Preview URL: | https://breaking-t-signature-legacy.vue-i18n-next.pages.dev |
kazupon
changed the title
$t overloaded signature for Legacy API mode$t overloaded signature for Legacy API mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feature (has breaking change)
In Vue I18n v9, it has a different interface from the Composition API mode and Legacy API mode of the
$toverloaded signature.Especially,
$tsignature in Legacy API mode has fewer overloaded signatures than in Composition API mode, as shown below:$toverloaded signatures$t(key: Path): TranslateResult;$t(key: Path, locale: Locale): TranslateResult;$t(key: Path, locale: Locale, list: unknown[]): TranslateResult;$t(key: Path, locale: Locale, named: NamedValue): TranslateResult;$t(key: Path, plural: number): TranslateResult;$t(key: Path, plural: number, options: TranslateOptions): TranslateResult;$t(key: Path, defaultMsg: string): TranslateResult;$t(key: Path, defaultMsg: string, options: TranslateOptions): TranslateResult;$t(key: Path, list: unknown[]): TranslateResult;$t(key: Path, list: unknown[], plural: number): TranslateResult;$t(key: Path, list: unknown[], defaultMsg: string): TranslateResult;$t(key: Path, list: unknown[], options: TranslateOptions): TranslateResult;$t(key: Path, named: Record<string, unknown>): TranslateResult;$t(key: Path, named: NamedValue, plural: number): TranslateResult;$t(key: Path, named: NamedValue, defaultMsg: string): TranslateResult;$t(key: Path, named: NamedValue, options: TranslateOptions): TranslateResult;Starting from v10, Legacy API mode can use the same
$toverload signature as Composition API mode.Reason: After that migration, when migrating to Composition API mode, we sometimes fall into a pitfall due to the different signature of
$t.