Fix IANA recommended plus hybrid NCSC-NL-TLS-2025-05 compliant curves#1962
Open
bwbroersma wants to merge 1 commit intointernetstandards:mainfrom
Conversation
sed -ri "s/^(ssl_ecdh_curve\s+)[a-zA-Z0-9:]+/\1$(curl -sSf "https://www.iana.org/assignments/tls-parameters/tls-parameters-8.csv"|awk -F, '$4=="Y"||$4=="N"&&$5~/ecdhe-mlkem/{print$2}'|tac|tr '\n' :|head -c-1)/" docker/webserver/nginx_templates/tls.conf.template
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sed -ri "s/^(ssl_ecdh_curve\s+)[a-zA-Z0-9:]+/\1$(curl -sSf "https://www.iana.org/assignments/tls-parameters/tls-parameters-8.csv"|awk -F, '$4=="Y"||$4=="N"&&$5~/ecdhe-mlkem/{print$2}'|tac|tr '\n' :|head -c-1)/" docker/webserver/nginx_templates/tls.conf.templateThis removes the non recommended IANA curves:
secp521r1brainpoolP512r1brainpoolP384r1brainpoolP256r1Note that the NCSC-NL also notes about the brainpool* curves (translated from Dutch):
@baknu already correctly noticed in the NCSC-NL-TLS-2025-05 content, I did not notice this text when I converted the Table 3 to a nginx TLS configuration.
Note I also dropped
secp521r1since it's not recommended by IANA.Note this moves
x25519in front ofsecp384r1, because it uses the reversed IANA order (withtac), while previously it was ordered on the cryptographic strength listed in Table 3 (with preference forx448andx25519over similar strengthsecp*).