Fix #1410 - Include sectxt notifications

internetstandards · Jun 18, 2024 · 326c99a · 326c99a
1 parent 5648f3e
commit 326c99a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/checks/tasks/securitytxt.py b/checks/tasks/securitytxt.py
@@ -143,5 +143,5 @@ def parser_format(parser_messages):
  "securitytxt_score": score,
  "securitytxt_found_host": result.found_host,
  "securitytxt_errors": errors,
- "securitytxt_recommendations": parser_format(parser.recommendations),
+ "securitytxt_recommendations": parser_format(parser.recommendations + parser.notifications),
  }
diff --git a/checks/test/test_securitytxt.py b/checks/test/test_securitytxt.py
@@ -213,6 +213,7 @@ def test_evaluate_securitytxt():
  b"Expires: 2050-09-01T00:00:00.000Z\n"
  b"Contact: mailto:[email protected]\n"
  b"Canonical: https://host/.well-known/security.txt\n"
+ b"unknown-field: https://host/.well-known/security.txt\n"
  ),
  url="https://example.com/security.txt",
  found_host="host",
@@ -228,5 +229,6 @@ def test_evaluate_securitytxt():
  {"msgid": "long_expiry", "context": {"line_no": 1}},
  {"msgid": "no_encryption", "context": {"line_no": None}},
  {"msgid": "not_signed", "context": {"line_no": None}},
+ {"msgid": "unknown_field", "context": {"line_no": None}},
  ],
  }