Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escape intercom settings (XSS). #250

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Escape intercom settings (XSS). #250

wants to merge 1 commit into from

Conversation

marshall-lee
Copy link

@marshall-lee marshall-lee commented Apr 5, 2017 •
edited
Loading

No description provided.

@evolve2k
Copy link

@marshall-lee Do you need to be changing the specs for this change?
At a glace I'd imagine you're only really wanting to change script_tag.rb.
Also CI has failed, need to get this passing I think before anyone will properly look at this and maybe add a comment here as to what you see as the issue.

@evolve2k
Copy link

evolve2k commented Aug 6, 2017

bump

@marshall-lee
Copy link
Author

@evolve2k yes, specs need to be changed because now we encode json differently (escaping has been added).
I rebased my branch, now CI fails only on some of the gemfiles.

@jonnyom jonnyom removed the backfill label Aug 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marshall-lee @evolve2k @jonnyom