Wrong request URL when conversation is assigned with "withRunningAssignmentRules" parameter #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "withRunningAssignmentRules" parameter is supposed to add "/run_assignment_rules" to the URL but instead it adds "/run_assignment_rules/parts". The API is throwing the 404 error when you attempt to send a request to this URL.
feelbadinc
changed the title
Eclairemoy
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
The withRunningAssignmentRules parameter is supposed to append
/run_assignment_rulesto the URL but instead it appends/run_assignment_rules/parts. The API is throwing the 404 error when you attempt to send a request to this URL.Intercom API doc article for the reference: https://developers.intercom.com/docs/references/rest-api/api.intercom.io/Conversations/autoAssignConversation/
How?
In original code, the
/partsstring is being appended to the URL no matter the value of withRunningAssignmentRules variable. I moved the/partsstring into the ternary expression so now it's appended only when withRunningAssignmentRules is false or undefined.