Frontend - Analyzables page #2865
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I suggest to change the target branch. Create another branch from develop and merge |
carellamartina
changed the title
drosetti
requested changes
May 15, 2025
|
|
||
| def get_queryset(self): | ||
| user = self.request.user | ||
| return super().get_queryset().visible_for_user(user) | ||
|
|
||
| @action(detail=False, methods=["post"]) |
There was a problem hiding this comment.
why a post insted of a get?
Comment on lines
+33
to
+60
| def test_list(self): | ||
| self.client.force_authenticate(user=self.user) | ||
| response = self.client.get(self.URL) | ||
| self.assertEqual(response.status_code, 200, response.content) | ||
| result = response.json() | ||
| self.assertIn("count", result) | ||
| self.assertEqual(result["count"], 1) | ||
|
|
||
| def test_get_analyzables(self): | ||
| self.client.force_authenticate(user=self.user) | ||
| response = self.client.post( | ||
| f"{self.URL}/get_analyzables", | ||
| data=["test.com"], | ||
| format="json", | ||
| ) | ||
| self.assertEqual(response.status_code, 200, response.content) | ||
| result = response.json() | ||
| self.assertEqual(result[0]["id"], self.an.pk) | ||
|
|
||
| self.client.force_authenticate(user=self.user) | ||
| response = self.client.post( | ||
| f"{self.URL}/get_analyzables", | ||
| data=["noanalyzable.com"], | ||
| format="json", | ||
| ) | ||
| self.assertEqual(response.status_code, 200, response.content) | ||
| result = response.json() | ||
| self.assertEqual(result[0]["tags"], ["not_found"]) |
There was a problem hiding this comment.
list and get_analyzables seems very similar, we need a custom API ? We cannot just call the list ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Please delete options that are not relevant.
Checklist
developdumpplugincommand and added it in the project as a data migration. ("How to share a plugin with the community")test_files.zipand you added the default tests for that mimetype in test_classes.py.FREE_TO_USE_ANALYZERSplaybook by following this guide.urlthat contains this information. This is required for Health Checks._monkeypatch()was used in its class to apply the necessary decorators.MockUpResponseof the_monkeypatch()method. This serves us to provide a valid sample for testing.# This file is a part of IntelOwl https://github.com/intelowlproject/IntelOwl # See the file 'LICENSE' for copying permission.Black,Flake,Isort) gave 0 errors. If you have correctly installed pre-commit, it does these checks and adjustments on your behalf.testsfolder). All the tests (new and old ones) gave 0 errors.DeepSource,Django Doctorsor other third-party linters have triggered any alerts during the CI checks, I have solved those alerts.Important Rules