Phunter Analyzer #2841

AnshSinghal · 2025-04-23T16:52:21Z

Closes #2286

Description

Please include a summary of the change and link to the related issue.

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue).
New feature (non-breaking change which adds functionality).
Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist

Important Rules

If you miss to compile the Checklist properly, your PR won't be reviewed by the maintainers.
Everytime you make changes to the PR and you think the work is done, you should explicitly ask for a review by using GitHub's reviewing system detailed here.

{
  "report": {
    "valid": "yes",
    "views": "1",
    "carrier": "reliance telecom pvt ltd",
    "location": "baghpat/baraut, uttar pradesh",
    "possible": "yes",
    "line_type": "fixed line",
    "local_time": "19:47:16",
    "spam_status": "Not spammer",
    "phone_number": "+911234567890",
    "national_format": "01234 567 890",
    "international_format": "+91 1234 567 890"
  },
  "data_model": null,
  "errors": [],
  "parameters": {}
}

integrations/phunter/app.py

AnshSinghal · 2025-04-24T10:25:27Z

@mlodic @fgibertoni Please review

fgibertoni

Can you also provide an example of analyzer's output ?

fgibertoni · 2025-04-28T06:52:12Z

api_app/analyzers_manager/classes.py

-        # Modified to support synchronous analyzer BBOT that return results directly in the initial response, avoiding unnecessary polling.
-        if analyzer_name == "BBOT_Analyzer":
+        # Modified to support synchronous analyzers that return results directly in the initial response, avoiding unnecessary polling.
+        if analyzer_name in ["BBOT_Analyzer", "Phunter"]:


I think that we should refactor this.
Maybe adding an avoid_polling parameter to the _docker_run function which defaults to False to keep compatibility.

fgibertoni · 2025-04-28T06:52:43Z

requirements/project-requirements.txt

@@ -89,6 +89,7 @@ pylnk3==0.4.2
 androguard==3.4.0a1 # version >=4.x of androguard raises a dependency conflict with quark-engine==25.1.1
 wad==0.4.6
 debloat==1.6.4
+phonenumbers==9.0.3


Not needed if in docker analyzer

The phunter.py is also using this module so that would need to be installed.

I think that performing the check twice is not necessary. I would keep it in docker analyzer only

Sure. But I believe it would be better in phunter.py so that it would instantly returns if invalid phone number is passed.

fgibertoni · 2025-04-28T06:54:11Z

integrations/phunter/compose.yml

+    container_name: phunter
+    restart: unless-stopped
+    expose:
+      - "5000"


intelowl_phoneinfoga container is already using this port. Please use a free one

fgibertoni · 2025-04-28T06:56:51Z

integrations/phunter/compose.yml

@@ -0,0 +1,11 @@
+services:
+  phunter:
+    image: intelowlproject/phunter:${REACT_APP_INTELOWL_VERSION}


Suggested change

image: intelowlproject/phunter:${REACT_APP_INTELOWL_VERSION}

image: intelowlproject/intelowl_phunter:${REACT_APP_INTELOWL_VERSION}

fgibertoni · 2025-04-28T06:57:01Z

integrations/phunter/compose.yml

+services:
+  phunter:
+    image: intelowlproject/phunter:${REACT_APP_INTELOWL_VERSION}
+    container_name: phunter


Suggested change

container_name: phunter

container_name: intelowl_phunter

fgibertoni · 2025-04-28T08:55:19Z

api_app/analyzers_manager/observable_analyzers/phunter.py

+                "spam_status": "Not spammer",
+                "phone_number": "+918929554991",
+                "national_format": "089295 54991",
+                "international_format": "+91 89295 54991",


Is this number real ? You should use a non existing number here

fgibertoni · 2025-04-28T08:56:22Z

api_app/analyzers_manager/observable_analyzers/phunter.py

+        except ValueError as e:
+            logger.error(f"[{self.name}] Invalid response format: {e}", exc_info=True)
+            raise AnalyzerRunException(f"Invalid response format from Phunter API: {e}")
+


If no error is raised then nothing is returned. We should use a default

Let's add a general Exception as fallback

😄 Didn't expect you to call for a general exception—tables have turned!

fgibertoni · 2025-04-28T09:49:22Z

integrations/phunter/app.py

+
+    try:
+        logger.info("Executing Phunter CLI tool")
+        command = ["python3", "phunter.py", "-t", formatted_number]


Maybe consider using shlex for safer escaping before using subprocess.run

Umm but as we are already using a list which i believe is safer and preferred. What you say?

The list is not escaping possible injection in formatted_number, so it would be safer to use shlex

fgibertoni · 2025-04-28T09:52:22Z

integrations/phunter/app.py

+
+if __name__ == "__main__":
+    logger.info("Starting Phunter Flask API...")
+    app.run(host="0.0.0.0", port=5000)


fgibertoni · 2025-04-28T09:52:42Z

integrations/phunter/app.py

+        )
+
+    except subprocess.CalledProcessError as e:
+        logger.error(f"Phunter CLI failed: {e.stderr}")


Remove this as said

integrations/phunter/app.py

fgibertoni

Replied in thread

AnshSinghal · 2025-05-03T05:50:07Z

@fgibertoni service_api_key needs to be added to the GitHub Actions secret.

github-actions · 2025-05-13T09:25:48Z

This pull request has been marked as stale because it has had no activity for 10 days. If you are still working on this, please provide some updates or it will be closed in 5 days.

fgibertoni · 2025-05-15T12:41:20Z

This should not be the issue stated here I think

AnshSinghal · 2025-05-15T12:51:00Z

But I believe the issue arising because of this only.

…

On Thu, 15 May 2025, 6:11 pm Federico Gibertoni, ***@***.***> wrote: *fgibertoni* left a comment (intelowlproject/IntelOwl#2841) <#2841 (comment)> This should not be the issue stated here I think — Reply to this email directly, view it on GitHub <#2841 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQGMMT6SHJ7I57IFG6BLN3D26SDQNAVCNFSM6AAAAAB3W3P2VKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQOBTGY3TQOBTG4> . You are receiving this because you authored the thread.Message ID: ***@***.***>

fgibertoni · 2025-05-16T09:01:50Z

I'm sorry you were right about the issue but the key had to be set in the test file.
You can pull the latest change from develop and should be fixed 😃

AnshSinghal · 2025-05-16T09:03:21Z

Sure. Will do the same

…

On Fri, 16 May 2025, 2:32 pm Federico Gibertoni, ***@***.***> wrote: *fgibertoni* left a comment (intelowlproject/IntelOwl#2841) <#2841 (comment)> I'm sorry you were right about the issue but the key had to be set in the test file. You can pull the latest change from develop and should be fixed 😃 — Reply to this email directly, view it on GitHub <#2841 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQGMMT6GTPUD5WFLP64SEGL26WSRLAVCNFSM6AAAAAB3W3P2VKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQOBWGA4TSOBVGY> . You are receiving this because you authored the thread.Message ID: ***@***.***>

AnshSinghal added 2 commits April 23, 2025 16:50

phunter

300cb3b

fixed DeepSource errors

d42f950

AnshSinghal force-pushed the phunter branch from 35d3ead to d42f950 Compare April 23, 2025 17:12

Merge branch 'develop' into phunter

5d260d1

github-advanced-security bot found potential problems Apr 23, 2025

View reviewed changes

integrations/phunter/app.py Fixed Show fixed Hide fixed

integrations/phunter/app.py Fixed Show fixed Hide fixed

integrations/phunter/app.py Fixed Show fixed Hide fixed

integrations/phunter/app.py Fixed Show fixed Hide fixed

integrations/phunter/app.py Fixed Show fixed Hide fixed

AnshSinghal added 3 commits April 24, 2025 07:01

fixed errors related to docker run method

4f9a601

fixed errors with sensitive data leaks

373e875

fixed wrong number issue

4aa4a06

fgibertoni requested changes Apr 28, 2025

View reviewed changes

fgibertoni marked this pull request as ready for review April 28, 2025 09:53

fixed some minor bugs in phunter

fb9084f

github-advanced-security bot found potential problems Apr 29, 2025

View reviewed changes

integrations/phunter/app.py Dismissed Show dismissed Hide dismissed

AnshSinghal requested a review from fgibertoni April 29, 2025 14:42

fgibertoni requested changes Apr 30, 2025

View reviewed changes

AnshSinghal added 3 commits May 2, 2025 20:19

used shlex and removed repeated phonenumber check

4fb7ba3

fixed migration issue

6caac86

cleaned

b32e62f

AnshSinghal requested a review from fgibertoni May 2, 2025 20:56

fixed migration file name

0c91e86

github-actions bot added the stale label May 13, 2025

github-actions bot removed the stale label May 17, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Phunter Analyzer #2841

Phunter Analyzer #2841

AnshSinghal commented Apr 23, 2025 •

edited

Loading

AnshSinghal commented Apr 24, 2025 •

edited

Loading

fgibertoni left a comment

fgibertoni Apr 28, 2025

AnshSinghal Apr 29, 2025

fgibertoni Apr 28, 2025

AnshSinghal Apr 29, 2025

fgibertoni Apr 30, 2025

AnshSinghal May 2, 2025 •

edited

Loading

fgibertoni Apr 28, 2025

fgibertoni Apr 28, 2025

fgibertoni Apr 28, 2025

fgibertoni Apr 28, 2025

fgibertoni Apr 28, 2025

fgibertoni Apr 30, 2025

AnshSinghal May 2, 2025

fgibertoni Apr 28, 2025

AnshSinghal Apr 29, 2025

fgibertoni Apr 30, 2025

AnshSinghal May 2, 2025

fgibertoni Apr 28, 2025

fgibertoni Apr 28, 2025

fgibertoni left a comment

AnshSinghal commented May 3, 2025

github-actions bot commented May 13, 2025

fgibertoni commented May 15, 2025

AnshSinghal commented May 15, 2025 via email

fgibertoni commented May 16, 2025

AnshSinghal commented May 16, 2025 via email

	image: intelowlproject/phunter:${REACT_APP_INTELOWL_VERSION}
	image: intelowlproject/intelowl_phunter:${REACT_APP_INTELOWL_VERSION}

Phunter Analyzer #2841

Are you sure you want to change the base?

Phunter Analyzer #2841

Conversation

AnshSinghal commented Apr 23, 2025 • edited Loading

Description

Type of change

Checklist

Important Rules

AnshSinghal commented Apr 24, 2025 • edited Loading

fgibertoni left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AnshSinghal May 2, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fgibertoni left a comment

Choose a reason for hiding this comment

AnshSinghal commented May 3, 2025

github-actions bot commented May 13, 2025

fgibertoni commented May 15, 2025

AnshSinghal commented May 15, 2025 via email

fgibertoni commented May 16, 2025

AnshSinghal commented May 16, 2025 via email

AnshSinghal commented Apr 23, 2025 •

edited

Loading

AnshSinghal commented Apr 24, 2025 •

edited

Loading

AnshSinghal May 2, 2025 •

edited

Loading