[UR][CUDA] Refactor reference counting in UR CUDA adapter using new ur::RefCount class #19287
+94
−131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martygrant
force-pushed
the
refCountRefactorCUDA
branch
from
e092022 to
e673ed1
Compare
martygrant
force-pushed
the
refCountRefactorCUDA
branch
from
e673ed1 to
01b85ac
Compare
martygrant
force-pushed
the
refCountRefactorCUDA
branch
from
01b85ac to
623451c
Compare
martygrant
force-pushed
the
refCountRefactorCUDA
branch
from
5f0b538 to
98af265
Compare
martygrant
force-pushed
the
refCountRefactorCUDA
branch
from
98af265 to
1e137bb
Compare
martygrant
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
martygrant
force-pushed
the
refCountRefactorCUDA
branch
from
fa4876f to
4cc4631
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #18644
Most UR adapters had their own reference counting of some sort. This adds a new RefCount class and refactors adapter code so all adapters can share the same code for reference counting. This PR handles CUDA and I will open more PRs for each adapter in turn.
I have kept the pre-existing reference counting members inside
stream_queue.hpp, temporarily renaming it asRefCountOldas the HIP adapter also uses this and want to only change one adapter per PR. I will change this file over when I open a PR for refactoring the HIP adapter.