Skip to content

[CI][Benchmarks] Remove 'passed' field from Result #19283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2025

Conversation

PatKamin
Copy link
Contributor

@PatKamin PatKamin commented Jul 3, 2025

It suffice to print just a single result failure within a single run. Use exceptions instead of a dedicated Result field.

@PatKamin PatKamin requested a review from a team as a code owner July 3, 2025 01:45
@PatKamin PatKamin temporarily deployed to WindowsCILock July 3, 2025 01:46 — with GitHub Actions Inactive
@PatKamin PatKamin temporarily deployed to WindowsCILock July 3, 2025 02:09 — with GitHub Actions Inactive
@PatKamin PatKamin temporarily deployed to WindowsCILock July 4, 2025 11:30 — with GitHub Actions Inactive
@PatKamin PatKamin force-pushed the remove-passed-field branch from 64f352b to 9d3bbbb Compare July 4, 2025 12:21
@PatKamin PatKamin temporarily deployed to WindowsCILock July 4, 2025 12:21 — with GitHub Actions Inactive
@PatKamin PatKamin temporarily deployed to WindowsCILock July 4, 2025 12:47 — with GitHub Actions Inactive
@PatKamin PatKamin temporarily deployed to WindowsCILock July 4, 2025 12:47 — with GitHub Actions Inactive
@PatKamin PatKamin force-pushed the remove-passed-field branch from 9d3bbbb to f12c898 Compare July 7, 2025 08:24
@PatKamin PatKamin temporarily deployed to WindowsCILock July 7, 2025 08:24 — with GitHub Actions Inactive
@PatKamin PatKamin temporarily deployed to WindowsCILock July 7, 2025 08:47 — with GitHub Actions Inactive
@PatKamin PatKamin temporarily deployed to WindowsCILock July 7, 2025 08:47 — with GitHub Actions Inactive
@PatKamin PatKamin force-pushed the remove-passed-field branch from f12c898 to d6ce33c Compare July 7, 2025 12:31
@PatKamin PatKamin temporarily deployed to WindowsCILock July 7, 2025 12:32 — with GitHub Actions Inactive
@PatKamin PatKamin temporarily deployed to WindowsCILock July 7, 2025 12:53 — with GitHub Actions Inactive
@PatKamin PatKamin temporarily deployed to WindowsCILock July 7, 2025 12:53 — with GitHub Actions Inactive
@PatKamin PatKamin force-pushed the remove-passed-field branch from d6ce33c to f283c39 Compare July 10, 2025 12:45
@PatKamin PatKamin force-pushed the remove-passed-field branch from f283c39 to 190a1b8 Compare July 10, 2025 12:55
It suffices to print just a single result failure within a single run.
Use exceptions instead of a dedicated Result field.
@PatKamin PatKamin requested a review from pbalcer July 10, 2025 14:00
@PatKamin
Copy link
Contributor Author

@intel/llvm-gatekeepers, please merge

@uditagarwal97 uditagarwal97 merged commit b68f49e into intel:sycl Jul 11, 2025
24 checks passed
@PatKamin PatKamin deleted the remove-passed-field branch July 11, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants