Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL][NFC] Use no output file instead of default output file in LIT tests #17362

Open
wants to merge 1 commit into
base: sycl
Choose a base branch
from
Open

[SYCL][NFC] Use no output file instead of default output file in LIT tests #17362

wants to merge 1 commit into from
+3 −3

Conversation

ayylol
Copy link
Contributor

@ayylol ayylol commented Mar 7, 2025

This occasionally causes errors on windows when multiple files compile to the same output file.

See #7872 for more context

@ayylol ayylol requested review from a team as code owners March 7, 2025 16:51
@ayylol ayylol requested a review from steffenlarsen March 7, 2025 16:51
@ayylol ayylol temporarily deployed to WindowsCILock March 7, 2025 16:51 — with GitHub Actions Inactive
sarnex
sarnex reviewed Mar 7, 2025
View reviewed changes
Copy link
Contributor

@sarnex sarnex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the goal to not output anything? if so maybe redirect to /dev/null?

sarnex
sarnex approved these changes Mar 7, 2025
View reviewed changes
Copy link
Contributor

@sarnex sarnex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

discussed offline

@ayylol ayylol temporarily deployed to WindowsCILock March 7, 2025 18:02 — with GitHub Actions Inactive
@ayylol ayylol temporarily deployed to WindowsCILock March 7, 2025 18:02 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cperkinsintel cperkinsintel cperkinsintel approved these changes

@sarnex sarnex sarnex approved these changes

@steffenlarsen steffenlarsen Awaiting requested review from steffenlarsen steffenlarsen is a code owner automatically assigned from intel/llvm-reviewers-runtime

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ayylol @cperkinsintel @sarnex