[SYCL][NATIVECPU] always inline kernels with -O3 #17360
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uwedolinsky
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
hvdijk
reviewed
Mar 7, 2025
| if (!NewF->hasFnAttribute(Attribute::AlwaysInline)) | ||
| NewF->addFnAttr(Attribute::AlwaysInline); | ||
| // Set internal linkage to enable removal of kernel after inlining | ||
| NewF->setLinkage(llvm::GlobalValue::LinkageTypes::InternalLinkage); |
There was a problem hiding this comment.
This is a behavioral change that probably should not depend on -O3, we should probably always adjust the linkage. If we do always adjust the linkage, do we still need AlwaysInline, or does the regular inliner already handle it then?
There was a problem hiding this comment.
The regular inliner might require increasing the threshold to inline large kernels, whereas the AlwaysInliner probably always works if the kernel is inlineable (which it should be). We probably want to keep the existing linkage on other optimisation levels to avoid potentially increasing code size for example when calling kernels from functions with multiple definitions.
uwedolinsky
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uwedolinsky
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inlines kernels into subhandler when compiling for -O3, and removes the kernels if inlining succeeded.