Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][CMake] Build RelWithDebInfo sycl runtimes with frame pointers #17342

Open
wants to merge 2 commits into
base: sycl
Choose a base branch
from

Conversation

tcreech-intel
Copy link
Contributor

Enable frame pointers on sycl runtimes when the build configuration is
Debug or RelWithDebInfo. (Though setting this will typically be a no-op
for Debug builds.)

Frame pointers improve the effectiveness of profilers, tracers, and
other introspection tools.

Enable frame pointers on sycl runtimes when the build configuration is
Debug or RelWithDebInfo. (Though setting this will typically be a no-op
for Debug builds.)

Frame pointers improve the effectiveness of profilers, tracers, and
other introspection tools.
@tcreech-intel tcreech-intel requested a review from jbrodman March 6, 2025 22:01
@tcreech-intel tcreech-intel marked this pull request as ready for review March 6, 2025 22:01
@tcreech-intel tcreech-intel requested a review from a team as a code owner March 6, 2025 22:01
@tcreech-intel
Copy link
Contributor Author

I was double-checking compile_commands.json and realized some compilations I was expecting to have the flag did not.
This is fixed in bb5484c, which also sets the flags for the object library as we do with (for example) code coverage options. The general idea is the same.

Copy link
Contributor

@bashbaug bashbaug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I didn't do a thorough check, but in my spot checks had -fno-omit-frame-pointer in the places where I expected to see it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants