Skip to content

[clang-linker-wrapper][NFC] Remove dead code #16879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Conversation

bader
Copy link
Contributor

@bader bader commented Feb 3, 2025

InputFiles variable defined in the function is not used. If statements below define local scope variables with the same name.

InputFiles variable defined in the function is not used. If statements
below define local scope variables with the same name.
@bader bader requested a review from a team as a code owner February 3, 2025 23:54
@bader bader requested a review from AlexeySachkov February 5, 2025 17:50
Copy link
Contributor

@asudarsa asudarsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch Alexey. I think this variable was missed as the code evolved over time.
Also, there will be considerable cleanup if/when we fully move to using clang-sycl-linker.

Thanks

@bader bader merged commit 4ca4115 into intel:sycl Feb 10, 2025
17 checks passed
@bader bader deleted the dead-code branch February 10, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants