Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary Android code #842

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rosetta-jpn
Copy link

This patches deletes

  • vaGetDisplay() in va_android.h
  • VA_DISPLAY_ANDROID in va_backend.h
  • libva-android in Android.bp

This patches deletes
- vaGetDisplay() in va_android.h
- VA_DISPLAY_ANDROID in va_backend.h
- libva-android in Android.bp
@rosetta-jpn
Copy link
Author

@XinfengZhang PTAL!

libva-intel-media-driver should be updated too like below.

diff --git a/Tools/MediaDriverTools/Android/mk/cmrt.tpl b/Tools/MediaDriverTools/Android/mk/cmrt.tpl
index 470cc64b3..84814cf01 100644
--- a/Tools/MediaDriverTools/Android/mk/cmrt.tpl
+++ b/Tools/MediaDriverTools/Android/mk/cmrt.tpl
@@ -53,6 +53,6 @@ LOCAL_MODULE := libigfxcmrt
 LOCAL_PROPRIETARY_MODULE := true
 
 LOCAL_LDLIBS := -lc -lva -lva-android
-LOCAL_SHARED_LIBRARIES := libc libdl libcutils liblog libutils libm libva libva-android
+LOCAL_SHARED_LIBRARIES := libc libdl libcutils liblog libutils libm libva
 
 include $(BUILD_SHARED_LIBRARY)
diff --git a/cmrtlib/Android.bp b/cmrtlib/Android.bp
index cb74de394..347d8e8de 100644
--- a/cmrtlib/Android.bp
+++ b/cmrtlib/Android.bp
@@ -71,7 +71,6 @@ cc_library_shared {
         "libutils",
         "libm",
         "libva",
-        "libva-android",
     ],
     vendor: true,
     enabled: false,

Copy link
Contributor

@XinfengZhang XinfengZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we need keep the PR here for some time, to ensure no one will be impacted by this PR, because it will force android user switch to drm path.

@rosetta-jpn
Copy link
Author

Sure.

Although I am not hurry at all on this patch, how long shall we wait?

@XinfengZhang
Copy link
Contributor

because it is non-backward compatible change(only for android), we are assuming that there are no one are using old interface, if this assumption is incorrect, we have to abandon this PR. so, we need to be careful, lets wait 2 weeks to check whether there is any objections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants