va/Android.mk: Fixes for compilation #728
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* defined to /system/etc by default, since anyone building libva-android can install a configuration file there.
* These libraries aren't exactly supposed to end up in /vendor, https://source.android.com/docs/core/architecture/vndk defined here. Only vendor specific items are supposed to be in /vendor.
* Allows libva-utils to compile with libva-android as well
xmao4-intel
reviewed
Jul 12, 2023
| @@ -25,8 +25,8 @@ | |||
|
|
|||
| LOCAL_PATH:= $(call my-dir) | |||
|
|
|||
| LIBVA_DRIVERS_PATH_32 := /vendor/lib/dri | |||
| LIBVA_DRIVERS_PATH_64 := /vendor/lib64/dri | |||
| LIBVA_DRIVERS_PATH_32 := /system/lib/dri | |||
There was a problem hiding this comment.
libva should be put at vendor partition since system partition is for android AOSP and can be updated seperately with vendor partition.
xmao4-intel
reviewed
Jul 12, 2023
| @@ -51,14 +51,14 @@ LOCAL_CFLAGS_64 += \ | |||
|
|
|||
| LOCAL_CFLAGS := \ | |||
| $(IGNORED_WARNNING) \ | |||
| -DSYSCONFDIR=\"/system/etc\" \ | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.