Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable unit test for ARM64/PowerPC architectures #267

Closed
wants to merge 2 commits into from
Closed

Disable unit test for ARM64/PowerPC architectures #267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da92819
Makefile: add architecture to CFLAGS
pablodelara Jan 2, 2024
e3ed308
erasure_code: disable unit tests temporarily for aarch64/ppc64le
pablodelara Jan 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Makefile.am
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,21 +60,25 @@ pkginclude_HEADERS += $(sort ${extern_hdrs})
libisal_la_SOURCES = ${lsrc}

if CPU_X86_64
ARCH=-Dx86_64
libisal_la_SOURCES += ${lsrc_x86_64}
other_tests += ${other_tests_x86_64}
endif

if CPU_X86_32
ARCH=-Dx86_32
libisal_la_SOURCES += ${lsrc_x86_32}
other_tests += ${other_tests_x86_32}
endif

if CPU_AARCH64
ARCH=-Daarch64
libisal_la_SOURCES += ${lsrc_aarch64}
other_tests += ${other_tests_aarch64}
endif

if CPU_PPC64LE
ARCH=-Dppc64le
libisal_la_SOURCES += ${lsrc_ppc64le}
other_tests += ${other_tests_ppc64le}
endif
Expand Down Expand Up @@ -132,7 +136,7 @@ CCAS = $(as_filter)
EXTRA_DIST += tools/yasm-filter.sh tools/nasm-filter.sh
EXTRA_DIST += tools/yasm-cet-filter.sh tools/nasm-cet-filter.sh

AM_CFLAGS = ${my_CFLAGS} ${INCLUDE} $(src_include) ${D}
AM_CFLAGS = ${my_CFLAGS} ${INCLUDE} $(src_include) ${ARCH} ${D}
if CPU_AARCH64
AM_CCASFLAGS = ${AM_CFLAGS}
else
Expand Down
6 changes: 5 additions & 1 deletion erasure_code/gf_vect_mul_test.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,7 @@ int main(int argc, char *argv[])
#endif
}

#if !defined(aarch64) && !defined(ppc64le)
// Test all unsupported sizes up to TEST_SIZE
for (size = 0; size < TEST_SIZE; size++) {
if (size % align != 0 && gf_vect_mul(size, gf_const_tbl, buff1, buff2) == 0) {
Expand All @@ -180,7 +181,10 @@ int main(int argc, char *argv[])
goto exit;
}
}

#else
printf
("WARNING: Test disabled on ARM & PPC due to known issue https://github.com/intel/isa-l/issues/263\n");
#endif
printf(" done: Pass\n");
fflush(0);

Expand Down
2 changes: 1 addition & 1 deletion make.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ endif

D :=
INCLUDE = $(patsubst %,-I%/,$(subst :, ,$(VPATH)))
CFLAGS = $(CFLAGS_$(arch)) $(CFLAGS_$(CC)) $(DEBUG) -O2 $(DEFINES) $(INCLUDE)
CFLAGS = $(CFLAGS_$(arch)) $(CFLAGS_$(CC)) $(DEBUG) -O2 $(DEFINES) $(INCLUDE) -D$(host_cpu)
ASFLAGS = $(ASFLAGS_$(arch)) $(ASFLAGS_$(CC)) $(DEBUG_$(AS)) $(DEFINES) $(INCLUDE)
ARFLAGS = $(ARFLAGS_$(arch))
DEFINES += $(addprefix -D , $D)
Expand Down
Loading