attempt to fix deployment #863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jongy
commented
Dec 6, 2023
| @@ -23,11 +23,6 @@ jobs: | |||
| fetch-depth: 0 | |||
| submodules: true | |||
|
|
|||
| - name: Get and verify tag value | |||
Jongy
commented
Dec 6, 2023
| @@ -122,11 +120,6 @@ jobs: | |||
| - name: Set up requirements | |||
| run: scripts/setup_runner_requirements.sh | |||
|
|
|||
| - name: Get and verify tag value | |||
Jongy
commented
Dec 6, 2023
| submodules: true | ||
| fetch-depth: 0 | ||
|
|
||
| - name: Verify release tag matches gProfiler version |
There was a problem hiding this comment.
Kept here as verification before deploying
Jongy
commented
Dec 6, 2023
| @@ -163,9 +165,6 @@ jobs: | |||
| name: gprofiler_aarch64 | |||
| path: output/ | |||
|
|
|||
| - name: Get tag value | |||
Jongy
commented
Dec 6, 2023
| docker image load < output/gprofiler_x86_64.img | ||
| docker tag gprofiler_x86_64 $X86_64_IMAGE | ||
| docker push $X86_64_IMAGE | ||
|
|
||
| # create manifests for the tag + for 'latest' | ||
| docker manifest create "$BASE_IMAGE" "$X86_64_IMAGE" "$AARCH64_IMAGE" |
There was a problem hiding this comment.
docker buildx imagetools create is the modern, preferable way
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See error: https://github.com/Granulate/gprofiler/actions/runs/7035079475/job/19145581611
Trying from https://stackoverflow.com/questions/75521775/buildx-docker-image-claims-to-be-a-manifest-list