Rework the metrics used by the FileTree #161
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Pennycook <[email protected]>
Presenting the amount of code used by all platforms as "coverage" is more aligned with how we describe CBI's functionality elsewhere. Signed-off-by: John Pennycook <[email protected]>
Signed-off-by: John Pennycook <[email protected]>
Small refactoring to enable later re-use. Signed-off-by: John Pennycook <[email protected]>
This has several advantages: - It wastes less whitespace than printing two SLOC counts. - The reader doesn't have to perform division to calculate coverage. - We can easily color-code coverage to highlight good/bad values. Signed-off-by: John Pennycook <[email protected]>
Pennycook
added
documentation
Signed-off-by: John Pennycook <[email protected]>
Signed-off-by: John Pennycook <[email protected]>
Signed-off-by: John Pennycook <[email protected]>
Signed-off-by: John Pennycook <[email protected]>
Computing coverage relative to a set of platforms enables the function to be used in more contexts. Signed-off-by: John Pennycook <[email protected]>
Signed-off-by: John Pennycook <[email protected]>
Signed-off-by: John Pennycook <[email protected]>
Signed-off-by: John Pennycook <[email protected]>
Signed-off-by: John Pennycook <[email protected]>
Signed-off-by: John Pennycook <[email protected]>
Signed-off-by: John Pennycook <[email protected]>
- Mention "platform coverage" in README and home page. - Add a description of "platform coverage" to the specialization page. Signed-off-by: John Pennycook <[email protected]>
Pennycook
force-pushed
the
metric-rework
branch
from
43fe59c to
ca90a0d
Compare
Signed-off-by: John Pennycook <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Proposed changes
FileTreeoutput by focusing in "coverage" metrics and removing redundant information.The new report output is much more readable than the old one:
I've opened this as a draft to ensure that we don't accidentally merge it before #158, but I think the functionality is ready for review.