Fix handling of symlink files #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original test_duplicates only covered the case where a codebase contains a directory that is a symlink to another directory; we did not have a corresponding test to cover the case where a codebase contains a source file that is a symlink to another source file. Signed-off-by: John Pennycook <[email protected]>
If a symlink and its target are both in the code base, we should only count the file's contributions to code divergence once. The simplest way to achieve this is to skip processing of the symlink when constructing the setmap. Signed-off-by: John Pennycook <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Fixes #132.
Proposed changes
setmapconstruction to ensure that symlinks are only counted once.