Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve documentation for github_repository #2265

Merged
merged 4 commits into from
Jun 14, 2024

Conversation

garysassano
Copy link
Contributor

@garysassano garysassano commented May 16, 2024

Current github_repository documentation doesn't mention the fact that you may get an inconsistent Terraform plan also for the properties related to allow_merge_commit and allow_squash_merge. When a GitHub App fails to retrieve the state of the repository's settings through the GET method, it will always try to apply new changes ignoring the current values.

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@garysassano garysassano force-pushed the fix-docs branch 3 times, most recently from b35cd07 to ca7911d Compare May 16, 2024 14:14
@nickfloyd nickfloyd enabled auto-merge (squash) June 14, 2024 18:39
@nickfloyd nickfloyd merged commit aa07277 into integrations:main Jun 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants