Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download stories when --load-cookies is used #2263

Merged
merged 3 commits into from
May 18, 2024

Conversation

ekalin
Copy link
Collaborator

@ekalin ekalin commented May 14, 2024

Fixes #2259.

Stories could only be downloaded if --login was used. I changed this to either --login or --load-cookies, which also logs the user in.

Otherwise the user needed to run Instaloader first just to import the cookies, and a second time (using the saved session) to actually download stories.

I've also changed error messages and the documentation in several places to refer to the process of logging in rather than to --login directly, but if you think that is too confusing, feel free to discard that commit.

  • Is it just a proof of concept? No
  • Is the documentation updated (if appropriate)? Yes
  • Do you consider it ready to be merged or is it a draft? Ready
  • Can we help you at some point? There's nothing I need help for, but I'm open to suggestions.

@aandergr
Copy link
Member

Thanks!

I also like the changes to the documentation and the wordings in output messages. To me it seems they make the program easier to understand and more user-friendly.

@aandergr aandergr merged commit 2531442 into instaloader:master May 18, 2024
7 checks passed
@ekalin ekalin deleted the cookie-stories branch May 18, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does not download stories when --load-cookies is passed
2 participants