Add Profile.bio_links property #2197
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aandergr
reviewed
Mar 18, 2024
| @@ -936,6 +936,11 @@ def followers(self) -> int: | |||
| def followees(self) -> int: | |||
| return self._metadata('edge_follow', 'count') | |||
|
|
|||
| @property | |||
| def bio_links(self) -> List[str]: | |||
| """list of external links given in the bio""" | |||
There was a problem hiding this comment.
Please also add a versionadded directive here, indicating it is new in version 4.12.
| @@ -936,6 +936,11 @@ def followers(self) -> int: | |||
| def followees(self) -> int: | |||
| return self._metadata('edge_follow', 'count') | |||
|
|
|||
| @property | |||
| def bio_links(self) -> List[str]: | |||
There was a problem hiding this comment.
It seems the bio_links structure provides much more than just the URLs, e.g. a title property that might be interesting as well. I would prefer this method to also return the other information.
[
{
"title": "",
"url": "http://taylorswift.com",
"link_type": "external"
},
{
"title": "THE TORTURED POETS DEPARTMENT 🤍",
"url": "https://taylor.lnk.to/thetorturedpoetsdepartment",
"link_type": "external"
},
{
"title": "Taylor Swift | The Eras Tour concert film",
"url": "https://taylor.lnk.to/TSTheErasTourFilm",
"link_type": "external"
}
]| @property | ||
| def bio_links(self) -> List[str]: | ||
| """list of external links given in the bio""" | ||
| return [links['url'] for links in self._metadata('bio_links')] if self._metadata('bio_links') else [] |
There was a problem hiding this comment.
I do not understand the purpose of if self._metadata('bio_links') here. If it evaluates to false due to an empty list, the left-hand statement would iterate an empty list and return an empty list, without that it needs to be explicitly checked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2186