New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use custom concurrent queue instead of DispatchQueue.global() #69

Open

uuttff8 wants to merge 1 commit into instacart:master from uuttff8:dont-use-global-queue

uuttff8 commented Jan 14, 2021

"Global queues easily lead to thread explosion and" and "Global queues also do not play nice with qos/priorities" :

https://gist.github.com/tclementdev/6af616354912b0347cdf6db159c37057


use custom concurrent queue

b9cd831

Contributor

ngoleo commented Mar 9, 2021

@uuttff8 looks like there's some swiftlint violations. do you mind fixing these?

/Users/travis/build/instacart/Nantes/Source/Classes/NantesLabel.swift:117:1: warning: Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)
/Users/travis/build/instacart/Nantes/Source/Classes/NantesLabel.swift:121:1: warning: Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment