[W.I.P] Fix: Waived control executes describe block #6807
+13
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for chef-inspec canceled.
|
Vasu1105
commented
Oct 19, 2023
| instance_eval(&block) | ||
|
|
||
| # By applying waivers *after* the instance eval, we assure that | ||
| # waivers have higher precedence than only_if. |
There was a problem hiding this comment.
Not seen any impact on the precedence even if _apply_waivers is called before instance_eval. Calling _apply_waivers here is required to get all the waiver data so that only in the valid condition we will evaluate the describe block, for example, if the run is set to true and if waiver is expired.
4 tasks
…e or the waiver is expired. This ensures the describe block of the waived control should not be executed. Signed-off-by: Vasu1105 <[email protected]> Signed-off-by: Vasu1105 <[email protected]>
Vasu1105
force-pushed
the
vj/fix-waivers-to-not-execute-describe-block-for-waived-controls
branch
from
7899adc
to
ea41ebc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Evaluates the describe block only if the waived control run is set to true or the waiver is expired. This ensures the describe block of the waived control should not be executed.
Waived control should not be executed and skipped without execution of describe block.
This change helps in eliminating the efforts to use options --filter-waived-controls and --retain-waiver-data.
Related Issue
Types of changes
Checklist: