Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AUTHENTICATE: support IRCv3.1 SASL PLAIN Authentication #179

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

AUTHENTICATE: support IRCv3.1 SASL PLAIN Authentication #179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f571e1
AUTHENTICATE: support IRCv3.1 SASL PLAIN Authentication
zachdecook Aug 19, 2022
2be16ce
Fixing style errors.
stickler-ci Aug 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pkg/ircslack/irc_context.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ type IrcContext struct {
SlackDebug bool
SlackConnected bool
ServerName string
IsAuthenticating bool
AuthBase64 string
Channels *Channels
Users *Users
ChunkSize int
Expand Down
63 changes: 63 additions & 0 deletions pkg/ircslack/irc_server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package ircslack

import (
"encoding/base64"
"errors"
"fmt"
"html"
Expand Down Expand Up @@ -28,6 +29,7 @@ type IrcCommandHandler func(*IrcContext, string, string, []string, string)

// IrcCommandHandlers maps each IRC command to its handler function
var IrcCommandHandlers = map[string]IrcCommandHandler{
"AUTHENTICATE": IrcAuthenticateHandler,
"CAP": IrcCapHandler,
"NICK": IrcNickHandler,
"USER": IrcUserHandler,
Expand Down Expand Up @@ -590,6 +592,67 @@ func IrcPassHandler(ctx *IrcContext, prefix, cmd string, args []string, trailing
}
}

// IrcAuthenticateHandler is called when an AUTHENTICATE command is sent
func IrcAuthenticateHandler(ctx *IrcContext, prefix, cmd string, args []string, trailing string) {
if len(args) != 1 {
log.Warningf("Invalid AUTHENTICATE command args: %v %v", args, trailing)
return
}
// Check mechanism
if !ctx.IsAuthenticating {
if args[0] != "PLAIN" {
log.Warningf("Un-implemented mechanism for AUTHENTICATE: %v", args[0])
if err := SendIrcNumeric(ctx, 904, "", "Unknown mechanism"); err != nil {
log.Warningf("Failed to send IRC message: %v", err)
}
return
}
if len(ctx.SlackAPIKey) > 0 {
if err := SendIrcNumeric(ctx, 907, "", "Already authenticated"); err != nil {
log.Warningf("Failed to send IRC message: %v", err)
}
}
// Ask for the data
if _, err := ctx.Conn.Write([]byte("AUTHENTICATE +\r\n")); err != nil {
log.Warningf("Failed to send IRC message: %v", err)
}
ctx.IsAuthenticating = true
return
}

if args[0] == "*" {
ctx.IsAuthenticating = false
if err := SendIrcNumeric(ctx, 906, "", "Aborted authentication"); err != nil {
log.Warningf("Failed to send IRC message: %v", err)
}
}
if args[0] != "+" {
ctx.AuthBase64 += args[0]
}
if len(args[0]) != 400 || args[0] == "+" {
// Decode RFC4616 PLAIN SASL message
plain, _ := base64.StdEncoding.DecodeString(ctx.AuthBase64)
split := strings.Split(string(plain), string(0))
// Is authzid RealName? Does this even matter since we're about to change it?
ctx.RealName = split[0]
ctx.OrigName = split[1]
ctx.SlackAPIKey = split[2]
if ctx.RealName == "" {
ctx.RealName = ctx.OrigName
}
ctx.FileHandler.SlackAPIKey = ctx.SlackAPIKey
// If we're ready, connect
if ctx.SlackClient == nil && ctx.RealName != "" && ctx.OrigName != "" {
if err := connectToSlack(ctx); err != nil {
log.Warningf("Cannot connect to Slack: %v", err)
// close the IRC connection to the client
ctx.Conn.Close()
}
}
ctx.IsAuthenticating = false
}
}

// IrcWhoHandler is called when a WHO command is sent
func IrcWhoHandler(ctx *IrcContext, prefix, cmd string, args []string, trailing string) {
sendErr := func() {
Expand Down