-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: docker improvements #4674
Open
Planlos5000
wants to merge
9
commits into
main
Choose a base branch
from
fs/docker-improvements
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
e7e183e
Add healthchecks to docker deployment
Planlos5000 3811d92
Ignore docker env file
Planlos5000 8fe0823
Fix paths documentation
Planlos5000 46efd14
Update and add env vars
Planlos5000 3ab2fde
Update caddy file
Planlos5000 eb70bb1
Combine gitignore
Planlos5000 35b5ec7
Update scrumlr version
Planlos5000 99789fa
Update documentation
Planlos5000 d4216ad
Merge branch 'main' into fs/docker-improvements
Lennart01 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,51 +1,63 @@ | ||
# example environment variables | ||
# read more about all env vars at https://docs.scrumlr.io/self-hosting/env-vars/ | ||
|
||
# Analytics (Plausible) | ||
ANALYTICS_DATA_DOMAIN= | ||
ANALYTICS_SRC= | ||
# Auth Providers | ||
## Scrumlr backend | ||
SCRUMLR_BACKEND_VERSION=3.10.2 | ||
SCRUMLR_SERVER_PORT=8080 | ||
SCRUMLR_BASE_PATH="/api" | ||
## Uses the hardcoded insecure key for development | ||
SCRUMLR_INSECURE= | ||
## JWT Private Key (ECDSA). Generate a new key for PRODUCTION | ||
SCRUMLR_PRIVATE_KEY= | ||
## NATS URL | ||
SCRUMLR_SERVER_NATS_URL="nats://nats:4222" | ||
## Redis if you use it instead of NATS | ||
REDIS_HOST= | ||
REDIS_USERNAME= | ||
REDIS_PASSWORD= | ||
## Webhook URL for feedback | ||
WEBHOOK_URL= | ||
## Auth Providers | ||
AUTH_CALLBACK_HOST= | ||
APPLE_CLIENT_ID= | ||
APPLE_CLIENT_SECRET= | ||
AZURE_AD_CLIENT_ID= | ||
AZURE_AD_CLIENT_SECRET= | ||
AZURE_AD_TENANT_ID= | ||
GITHUB_CLIENT_ID= | ||
GITHUB_CLIENT_SECRET= | ||
GOOGLE_CLIENT_ID= | ||
GOOGLE_CLIENT_SECRET= | ||
MICROSOFT_CLIENT_ID= | ||
MICROSOFT_CLIENT_SECRET= | ||
GITHUB_CLIENT_ID= | ||
GITHUB_CLIENT_SECRET= | ||
AZURE_AD_TENANT_ID= | ||
AZURE_AD_CLIENT_ID= | ||
AZURE_AD_CLIENT_SECRET= | ||
APPLE_CLIENT_ID= | ||
APPLE_CLIENT_SECRET= | ||
OIDC_CLIENT_ID= | ||
OIDC_CLIENT_SECRET= | ||
OIDC_DISCOVERY_URL=http://oidc.localhost:5556/dex/.well-known/openid-configuration | ||
# Session Secret | ||
SESSION_SECRET= | ||
# Your Postgres Password | ||
POSTGRES_PASSWORD= | ||
# Redis if you use it instead of NATS | ||
REDIS_HOST= | ||
REDIS_PASSWORD= | ||
REDIS_USERNAME= | ||
# API Base Path | ||
SCRUMLR_BASE_PATH="/api" | ||
# Uses the hardcoded insecure key for development | ||
SCRUMLR_INSECURE= | ||
# Frontend Port | ||
SCRUMLR_ENABLE_EXPERIMENTAL_AUTH_FILE_SYSTEM_STORE= | ||
|
||
## Scrumlr frontend | ||
SCRUMLR_FRONTEND_VERSION=3.10.2 | ||
SCRUMLR_LISTEN_PORT=8080 | ||
# JWT Private Key (ECDSA). Generate a new key for PRODUCTION | ||
SCRUMLR_PRIVATE_KEY= | ||
# NATS URL | ||
SCRUMLR_SERVER_NATS_URL="nats://nats:4222" | ||
# Server Port | ||
SCRUMLR_SERVER_PORT=8080 | ||
# Server URL | ||
SCRUMLR_SERVER_URL="/api" | ||
# Show Legal Documents (Cookie Policy, Privacy Policy, Terms of Service) | ||
SCRUMLR_SHOW_LEGAL_DOCUMENTS=true | ||
# Websocket URL (wss:// or ws://) | ||
## Websocket URL (wss:// or ws://) | ||
# SCRUMLR_WEBSOCKET_URL="ws://localhost:8080/api" | ||
# Webhook URL for feedback | ||
WEBHOOK_URL= | ||
## Show Legal Documents (Cookie Policy, Privacy Policy, Terms of Service) | ||
SCRUMLR_SHOW_LEGAL_DOCUMENTS=true | ||
## Analytics (Plausible) | ||
ANALYTICS_DATA_DOMAIN= | ||
ANALYTICS_SRC= | ||
SCRUMLR_CLARITY_ID= | ||
|
||
## Postgres | ||
POSTGRES_VERSION=17.2 | ||
POSTGRES_USER= | ||
POSTGRES_PASSWORD= | ||
POSTGRES_DB= | ||
|
||
## Nats | ||
NATS_VERSION=2.10.24 | ||
|
||
## Caddy | ||
CADDY_VERSION=2.9.1 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,14 @@ | ||
0.0.0.0:80 { | ||
log { | ||
output stdout | ||
} | ||
@api { | ||
path /api* | ||
} | ||
reverse_proxy @api scrumlr-backend:8080 | ||
:80 { | ||
log { | ||
output stdout | ||
} | ||
@api { | ||
path /api* | ||
} | ||
reverse_proxy @api scrumlr-backend:{$SCRUMLR_SERVER_PORT} | ||
|
||
@frontend { | ||
path / /static* /locales* /login* /board* /new* /timer_finished.mp3 /hotkeys.pdf /legal/* /manifest.json /service-worker.js | ||
} | ||
reverse_proxy @frontend scrumlr-frontend:8080 | ||
@frontend { | ||
path / /static* /locales* /login* /board* /new* /timer_finished.mp3 /hotkeys.pdf /legal/* /manifest.json /service-worker.js | ||
} | ||
reverse_proxy @frontend scrumlr-frontend:{$SCRUMLR_LISTEN_PORT} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here and in the other images, would it make sense to use
latest
as the fallback version if the specific env var isn't set? then we wouldn't need to adjust the version value with every releaseThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
latest would potentially pull development images.
We probably dont want that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok fair, and what about the idea of using
docker tag
to tag the latest release asstable
or something along those lines? This could maybe be automated in the release process as well.