Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: unit tests for api layer #4161

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

test: unit tests for api layer #4161

wants to merge 12 commits into from

Conversation

mateo-ivc
Copy link
Contributor

Description

Implemented unittests for api/columns.go

Changelog

api/columns_test.go

  • Added tests for the various functions in api/columns.go

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • The light- and dark-theme are both supported and tested
  • The design was implemented and is responsive for all devices and screen sizes
  • The application was tested in the most commonly used browsers (e.g. Chrome, Firefox, Safari)

(Optional) Visual Changes

@mateo-ivc mateo-ivc changed the title Mi/add api tests test: unittests for api layer May 23, 2024
@mateo-ivc mateo-ivc changed the title test: unittests for api layer test: unit tests for api layer May 23, 2024
@octomind-dev OctoMind-dev
Copy link

octomind-dev bot commented May 23, 2024 •
edited
Loading

🐙 Octomind

Test Report: 0/14 successful.

description status details
About Section Visibility Test Failed ❌ click
change avatar Failed ❌ click
check Privacy Policy Failed ❌ click
check terms & conditions Failed ❌ click
close cookie banner - front page Failed ❌ click
close cookie banner - sign-in Failed ❌ click
create and delete board columns Failed ❌ click
create_and_delete_notes_and_actions_v2 Failed ❌ click
create lean coffee board Failed ❌ click
edit_notes_and_actions_v5 Failed ❌ click
get started Failed ❌ click
share_session Failed ❌ click
sign-in Failed ❌ click
test all ways to open the setup flow Failed ❌ click

commit sha: 4a58c96

@mateo-ivc mateo-ivc self-assigned this May 23, 2024
@octomind-dev OctoMind-dev
Copy link

octomind-dev bot commented May 24, 2024 •
edited
Loading

🐙 Octomind

Test Report: 0/14 successful.

description status details
About Section Visibility Test Failed ❌ click
change avatar Failed ❌ click
check Privacy Policy Failed ❌ click
check terms & conditions Failed ❌ click
close cookie banner - front page Failed ❌ click
close cookie banner - sign-in Failed ❌ click
create and delete board columns Failed ❌ click
create_and_delete_notes_and_actions_v2 Failed ❌ click
create lean coffee board Failed ❌ click
edit_notes_and_actions_v5 Failed ❌ click
get started Failed ❌ click
share_session Failed ❌ click
sign-in Failed ❌ click
test all ways to open the setup flow Failed ❌ click

commit sha: dce444c

@octomind-dev OctoMind-dev

This comment has been minimized.

Sign in to view
@mateo-ivc mateo-ivc added the Review Needed This pull request is ready for review label Jun 3, 2024
wischoepke
wischoepke reviewed Jan 14, 2025
View reviewed changes
Copy link

@wischoepke wischoepke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are there no tests for the API files: board_reaction, boards, etc.?"

server/src/api/columns_test.go Show resolved Hide resolved
server/src/api/columns_test.go Outdated Show resolved Hide resolved
server/src/api/columns_test.go Show resolved Hide resolved
server/src/api/columns_test.go Outdated Show resolved Hide resolved
server/src/api/columns_test.go Show resolved Hide resolved
server/src/api/columns_test.go Outdated Show resolved Hide resolved
server/src/api/columns_test.go Outdated Show resolved Hide resolved
@octomind-dev OctoMind-dev

This comment has been minimized.

Sign in to view
@octomind-dev OctoMind-dev

This comment has been minimized.

Sign in to view
@octomind-dev OctoMind-dev

This comment has been minimized.

Sign in to view
wischoepke
wischoepke approved these changes Jan 22, 2025
View reviewed changes
Copy link

@wischoepke wischoepke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review is done

mateo-ivc and others added 11 commits January 22, 2025 14:08
@mateo-ivc @wischoepke
basic test cases for api/columns
1c0c734
@mateo-ivc @wischoepke
add unit tests for board
38a9f81
@mateo-ivc @wischoepke
add unit tests for board
2315213
@wischoepke
add unit tests for board
73acd72
@wischoepke
chore: The first steps for the transition to mockery
21ad79d 
in the API layer have been completed.
Next, we still need to implement mockery in all
API tests and delete the manual interfaces

steps to todo:
* remove old manual written interface mock implementation,
* adapt api tests,
* enhance readme for mockery setup.
@wischoepke
feat: commit mockery generated interface
30c29c3 
implementations
@wischoepke
chore: generate only needed mocks and
f8b418e 
adapt readme for mockery
@wischoepke
refactor: replace test content structure with
7ddeab7 
TestParameterBundle usage in columns test
@wischoepke
refactor: remove commented code
0ea7c49
@wischoepke
refactor: refactor notes tests with mockery mocks
b24f6df
@wischoepke
refactor: replace custom mock implementations
b721a02 
with mockery
@octomind-dev OctoMind-dev
Copy link

octomind-dev bot commented Jan 22, 2025 •
edited
Loading

🐙 Octomind

Test Report: 14/14 successful.

description status details
About Section Visibility Test Passed ✅ click
change avatar Passed ✅ click
check Privacy Policy Passed ✅ click
check terms & conditions Passed ✅ click
close cookie banner - front page Passed ✅ click
close cookie banner - sign-in Passed ✅ click
create and delete board columns Passed ✅ click
create_and_delete_notes_and_actions_v2 Passed ✅ click
create lean coffee board Passed ✅ click
edit_notes_and_actions_v5 Passed ✅ click
get started Passed ✅ click
share_session Passed ✅ click
sign-in Passed ✅ click
test all ways to open the setup flow Passed ✅ click

commit sha: 1cb51da

@github-actions GitHub Actions
Copy link

The deployment to the dev cluster was successful. You can find the deployment here: https://4161.development.scrumlr.fra.ics.inovex.io
This deployment is only for testing purposes and will be deleted after 1 week.
To redeploy rerun the workflow.
DO NOT STORE IMPORTANT DATA ON THIS DEPLOYMENT

Deployed Images

  • ghcr.io/inovex/scrumlr.io/scrumlr-frontend:sha-ef98d87

  • ghcr.io/inovex/scrumlr.io/scrumlr-server:sha-ef98d87

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wischoepke wischoepke wischoepke approved these changes

Assignees

@mateo-ivc mateo-ivc

Labels
Review Needed This pull request is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mateo-ivc @wischoepke @Lennart01