refactor: small refactoring of voting result processing

inovex · Feb 4, 2025 · fe995b1 · fe995b1
1 parent 9480070
commit fe995b1
Showing 1 changed file with 6 additions and 9 deletions.
diff --git a/server/src/votes/service.go b/server/src/votes/service.go
@@ -81,18 +81,15 @@ func getVotingWithResults(voting database.Voting, votes []database.Vote) *Voting
 		return nil
 	}
 
-	var votesForVoting []database.Vote
-	for _, vote := range votes {
-		if vote.Voting == voting.ID {
-			votesForVoting = append(votesForVoting, vote)
-		}
-	}
+	relevantVoting := technical_helper.Filter[database.Vote](votes, func(vote database.Vote) bool {
+		return vote.Voting == voting.ID
+	})
 
-	if len(votesForVoting) > 0 {
-		votingResult := VotingResults{Total: len(votesForVoting), Votes: map[uuid.UUID]VotingResultsPerNote{}}
+	if len(relevantVoting) > 0 {
+		votingResult := VotingResults{Total: len(relevantVoting), Votes: map[uuid.UUID]VotingResultsPerNote{}}
 		totalVotePerNote := map[uuid.UUID]int{}
 		votesPerUser := map[uuid.UUID][]uuid.UUID{}
-		for _, vote := range votesForVoting {
+		for _, vote := range relevantVoting {
 			if _, ok := totalVotePerNote[vote.Note]; ok {
 				totalVotePerNote[vote.Note] = totalVotePerNote[vote.Note] + 1
 				votesPerUser[vote.Note] = append(votesPerUser[vote.Note], vote.User)