fix: ZEP Adapter #115
Merged
fix: ZEP Adapter #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alxndr13
commented
Jan 12, 2024
alxndr13
commented
- fix: zep needs to fulfill the configurable interface
- docs: update docs for the zep adapter
| @@ -54,7 +54,7 @@ func (zep *CalendarAPI) Name() string { | |||
| return "ZEP CalDav API" | |||
| } | |||
|
|
|||
| func (zep *CalendarAPI) Initialize(ctx context.Context, calendarID string, config map[string]interface{}) error { | |||
There was a problem hiding this comment.
It would really be useful if an adapter implementation could import the adapter package, then would could simply assert that the adapter implements the Configurable interface using var _ adapter.Configurable = &CalendarAPI{}. But unfortunately that ends with an import cycle.
I'll try to come up with a solution later on -> separate PR.
MichaelEischer
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.