Trailing slashes for directory watches

[toconnor]

inotifytools_watch_files() will append a / to any filename that is
is a directory before invoking create_watch()

update watch_from_filename() to search for filenames with a trailing /
if filename itself isn't found in tree_filename first

[ericcurtin]

@toconnor I'd like to merge this if at all possible. How could I reproduce the issue? Even better if you could add an integration test or a unit test.

[toconnor]

@ericcurtin I no longer have access to the original codebase where I encountered this issue. I'll have to see if I can reproduce this issue. From what I can remember, if I created a watch on a directory, if the path string did not have a trailing slash, inotifytools would add one (

inotify-tools/libinotifytools/src/inotifytools.c

Lines 1017 to 1024 in cfa93aa

	// Always end filename with / if it is a directory
	if ( !isdir(filenames[i])
	|| filenames[i][strlen(filenames[i])-1] == '/') {
	filename = strdup(filenames[i]);
	}
	else {
	nasprintf( &filename, "%s/", filenames[i] );
	}

). If I went to query for the watch handle using a path string without a trailing slash (i.e., the exact string I passed to inotifytools_watch_files()), watch_from_filename() wouldn't find the watch.

[ericcurtin]

@toconnor ok no problem :)

Just remember to respect backwards compatibility