Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of the global logger #200

Merged
merged 4 commits into from
Nov 14, 2024
Merged

Get rid of the global logger #200

merged 4 commits into from
Nov 14, 2024

Conversation

sHermanGriffiths
Copy link
Contributor

Describe Your Changes

The use of the global logger resulted in the configuration of the logger in any project that uses the n2y package. This is obviously not the desired effect, as we want n2y users to be able to use our package and configure their logging system the way they would like.

How Did You Test It

I loaded n2y in a project and ensured that the project's logging configuration was used and not the n2y package's.

Copy link
Member

@ReeceStevens ReeceStevens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just one minor comment. I always have to remind myself how Python logging works in situations like these!

n2y/plugins/internallinks.py Show resolved Hide resolved
Copy link
Member

@ReeceStevens ReeceStevens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sHermanGriffiths sHermanGriffiths merged commit 4eb2ec2 into main Nov 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants