Updated state interfaces #1325
Merged
Updated state interfaces #1325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyhb
requested review from
djfarrelly,
darwin67,
goodoldneon and
jpwilliams
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tonyhb
force-pushed
the
feature/state-interfaces
branch
2 times, most recently
from
8af10bd
to
e71eb59
Compare
darwin67
requested changes
May 7, 2024
| if err != nil { | ||
| // generate a new one here to be used for subsequent runs. | ||
| // this could happen for runs that started before this feature was introduced. | ||
| sid := telemetry.NewSpanID(ctx) | ||
| fnSpanID = &sid | ||
| // TODO: Save span ID // UPDATE? |
There was a problem hiding this comment.
it should only save if metadata doesn't have a spanID already stored.
this is likely required if people do future scheduling with event.ts or just sleeps for a long time.
though the function run will look weird in that case since it'll look like the function started from the middle.
or we just don't care since it's no longer an issue once outside the history window.
tonyhb
force-pushed
the
feature/state-interfaces
branch
from
e148c5c
to
df95d53
Compare
tonyhb
force-pushed
the
feature/state-interfaces
branch
from
65cf82a
to
d5c0053
Compare
jpwilliams
reviewed
May 10, 2024
tonyhb
force-pushed
the
feature/state-interfaces
branch
from
b1aa107
to
f52e6e9
Compare
tonyhb
force-pushed
the
feature/state-interfaces
branch
from
cafff08
to
a961136
Compare
We were missing tenant information in some calls to the v2 state interface. We'll be using the accountId for progressively rolling out the new interface.
jpwilliams
approved these changes
May 21, 2024
8 tasks
darwin67
added a commit
that referenced
this pull request
May 22, 2024
Embed the event data into pauses so they can be referenced when needed for spans. Also update some data reference due to changes from #1325 CronSchedule is removed from the data structure since it's not referenced anywhere, and is embedded into `Context` map instead. --------- Co-authored-by: Darwin D Wu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change (choose one)
Checklist
Check our Pull Request Guidelines