Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry On Error #924

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

erlendp
Copy link

@erlendp erlendp commented Sep 5, 2023

Occasionally the render process fails, and it would be desirable to allow the render to immediately try again under certain conditions, such as aerender exiting with a non-zero exit code.

This PR adds the ability for the user to supply a custom onShouldRetry function to trigger a retry as required.

@erlendp erlendp marked this pull request as draft September 5, 2023 00:57
@inlife inlife marked this pull request as ready for review September 13, 2023 09:50
@inlife
Copy link
Owner

inlife commented Sep 13, 2023

I like the idea! @erlendp do you want to add more work here?

Copy link

stale bot commented Nov 12, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale label Nov 12, 2023
@inlife inlife removed the Stale label Nov 14, 2023
Copy link

stale bot commented Jan 18, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale label Jan 18, 2024
@inlife inlife removed the Stale label Jan 18, 2024
Copy link

@sharukh967 sharukh967 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@JamesBotterill
Copy link
Contributor

Any movement on this as it would be a very useful thing to have

@JamesBotterill
Copy link
Contributor

Only change I can see that would be needed, is that we limit the number of retries a render can have when erroring out.

Worry could be that we get stuck in a render loop when it's dealing with an issue where an render is erroring out everytime

@JamesBotterill
Copy link
Contributor

@inlife On further review I propose the following changes

  1. Right now onShouldRetry is set as event, not as an option flag. This should be set as a flag option "--retry-on-error" (defaulted to false)
  2. A second flag "--number-of-retries" should be added as an Number (default to 1) which sets the number of times a render should be retried before erroring out (to avoid infinite loop)

As it looks like OP has abandoned the change, I'll try and find time to do this.

@inlife
Copy link
Owner

inlife commented Apr 29, 2024

Awesome, will be looking forward. Big thanks for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants