-
Notifications
You must be signed in to change notification settings - Fork 0
chore(deps): pin signet-sdk to commit before larger update #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
For the current PRs to work without a huge rebase, we need to pin signet-sdk to the commit before what's in main, to use the old deps.
My PR depends on a branch in the SDK |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎀 Graphite made me write something 🦀
uhhh that's kinda tough. That means we'll need to update deps and all open PRs will need to rebase, which will be painful. Any workaround or will y'all eat the bugs? |
Yeah, looking at the open PRs, i think it's best to:
|
My PR is stacked on @prestwich PRs already, so it would be better to stack the So instead we should:
This will allow |
|
to be clearer, this PR restores the status quo, ie. It explicitly depends on a pre-change sdk commit. So it won't require any changes to open PRs my preferred is
|
ya my point with this pr is to restore status quo—we don't want to merge the ongoing work with red CI |
For the current PRs to work without a huge rebase, we need to pin signet-sdk to the commit before what's in main, to use the old deps.