Skip to content

chore(deps): pin signet-sdk to commit before larger update #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Evalir
Copy link
Member

@Evalir Evalir commented May 23, 2025

For the current PRs to work without a huge rebase, we need to pin signet-sdk to the commit before what's in main, to use the old deps.

For the current PRs to work without a huge rebase, we need to pin signet-sdk to the commit before what's in main, to use the old deps.
Copy link
Member Author

Evalir commented May 23, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

My PR depends on a branch in the SDK dylan/block-number though, so the pin will need to contain those changes.

Copy link
Contributor

@dylanlott dylanlott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎀 Graphite made me write something 🦀

@Evalir
Copy link
Member Author

Evalir commented May 23, 2025

uhhh that's kinda tough. That means we'll need to update deps and all open PRs will need to rebase, which will be painful.

Any workaround or will y'all eat the bugs?

@Evalir Evalir requested a review from dylanlott May 23, 2025 21:00
@Evalir
Copy link
Member Author

Evalir commented May 23, 2025

Yeah, looking at the open PRs, i think it's best to:

  • merge this PR as is
  • merge prestwich's PRs
  • update to newer sdk/alloy/trevm/reth
  • merge your PR

Copy link
Contributor

My PR is stacked on @prestwich PRs already, so it would be better to stack the builder changes for revm / alloy on top of my submit refactors.

So instead we should:

  • Close this PR
  • Merge the env and cache integration PRs
  • Merge my submit refactors, keeping the signet-sdk dep pointed at dylan/block-number
  • Update alloy / revm versions, and fix the bugs that incurs and then set the sdk branch back to main

This will allow alloy and revm update work to occur simultaneously with ongoing submit and simulation debugging.

@prestwich
Copy link
Member

main is currently broken. so fixing main is the first priority. I vote for merging this, then restacking the open PRs

@prestwich
Copy link
Member

prestwich commented May 24, 2025

to be clearer, this PR restores the status quo, ie. It explicitly depends on a pre-change sdk commit. So it won't require any changes to open PRs

my preferred is

  • merge this
  • all open prs
  • updates

@Evalir Evalir enabled auto-merge (squash) May 25, 2025 16:49
@Evalir
Copy link
Member Author

Evalir commented May 25, 2025

ya my point with this pr is to restore status quo—we don't want to merge the ongoing work with red CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants